Edward Faulkner

Results 713 comments of Edward Faulkner

For your use case, pulling all the snippets out only to put them back in again later is just unnecessary steps. Instead of extracting all the snippets, you need a...

Status update: the last remaining piece of implementation here was going to be exposing the new runtime template compiler to classic builds. But @kategengler and I discovered that this is...

We definitely let some breaking behavior out in 1.17.0 that wasn't intentional. Specifically, importSync became always eager.

Note from our debugging on this: - babel-plugin-debug-macros is copying the predicate expression as a prefix before deprecate(), the predicate expression is itself a use of embroider macros, the interaction...

Another thing you mentioned was "i18n" getting renamed to "iN". That should be fixed via babel-import-util 3.0.1 now, it's a compatible patch so as long as you're re-downloading the packages...

If we put the new resolver into ember-source itself, we can also change its relationship to Application if we want to. The only reason it exists as a class was...

Discussion notes from RFC review: - ideally it would be better to think of inspector's current `ember_debug` library as the beginning of the polyfill of the API that we would...

Thanks for reporting. I'm not sure how to reproduce this. Maybe you can try eliminating addons to see if one is responsible. vendor-prefix.js is a thing added by ember-cli itself.

`keepAssets` only needs to exist for preserving the JS imports of assets. If there are no imports, that's really not what `keepAssets` is for. A plugin like [copy](https://www.npmjs.com/package/rollup-plugin-copy) is probably...