Eero Lehtinen
Eero Lehtinen
Yeah my Android 11 phone with Mali-G76 MC4 GPU works fine.
Does this allow avoiding the RG11B10UFLOAT_RENDERABLE requirement by tonemapping into rgba8? That would be nice for me personally.
I guess at this point I would be happy if there was a small mention in the documentation that large values are allowed with HDR, and `Mul` implementation for Srgb...
> I've been using the [palette](https://docs.rs/palette/0.7.4/palette/) crate as inspiration for what methods and traits to support - but only as a starting point, not as a rigid spec. Now, `palette`...
We do have [a tonemapping pipeline](https://docs.rs/bevy/latest/bevy/core_pipeline/tonemapping/enum.Tonemapping.html) already, if this is what you mean. We don't need to do any tonemapping in bevy_color.
Ok I found that the palette library has [a stimulus trait](https://github.com/Ogeon/palette/blob/e75eab2fb21af579353f51f6229a510d0d50a311/palette/src/stimulus.rs), that does at least mention that high color values exist. Color is called stimulus in our tonemapping shader too.
On android, the app always crashes for me when resuming and starts from the beginning. ``` 05-24 02:33:26.100 20678 20768 I RustStdoutStderr: thread '' panicked at /home/eero/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ndk-context-0.1.1/src/lib.rs:87:5: 05-24 02:33:26.100 20678...
> On android, the app always crashes for me when resuming and starts from the beginning. I did some more testing on Android and it seems that the crashing might...
I also tested with opt-level=3 and lto="thin", and then the time window for making the music bug happen is very very small. I couldn't make it happen in practice, maybe...
Rounding after scaling is the correct way to do things. That previous fix only works around the floating point imprecision of our rounding method. We should really only do the...