Pieter Eendebak

Results 69 comments of Pieter Eendebak

@jklymak Would you be able to review this pr? Thanks

> Why add an additional flag to `update` rather than extracting the rcparam values and passing them in `clear` (where we have to add a call to `update` anyway)? >...

@carljm This PR was closed because the deprecation would impact too many users. What about the following variation? Add a kwarg with values `False`, `True` and `None`. * Value `True`...

PR looks good to me. The status is awaiting merge. I guess @ethanfurman will have to do that.

I have made the requested changes; please review again

@tiran Would you be able to continue the review? If not, I will try to find another core dev to review.

I have made the requested changes; please review again. If there are any more changes required for PEP7, let me know

@erlend-aasland Will you be able to continue reviewing the PR?

> > @erlend-aasland Will you be able to continue reviewing the PR? > > Yes, sorry for the delay. I can review it by next weekend. @erlend-aasland Gentle ping