Pieter Eendebak

Results 69 comments of Pieter Eendebak

@melvinvermeeren Thanks for the reply. The `EXTRACT_PRIVATE` is already set to False for my project. But this parameter only applied to the documentation generated by doxygen, not the xml data....

> Would this work if SymPy was using the PyPI multipledispatch module? I'd really like to get rid of SymPy's multipledispatch module and use that instead. The pypi multipledispatch and...

@asmeurer I merged the generation with `bin/ask_update.py`. It turns out that the generated rules are not system independent. The logic is the same, but the ordering of the rules is...

> Sorting sounds good. I'm assuming that's done when we pregenerate the rules and not at runtime. Yes, only in pre-generation. The sorting is applied to the order of arguments...

> I was thinking something like this: > > ```python > from collections import defaultdict > > ... > ... > > def print_rules(): > for line in all_lines(): >...

@oscarbenjamin I added the `lazy_function` to the PR (with a `__str__` and `__repr__` added). We could pass also `__annotations__`, or even pass any attribute, but I have no strong preference...

> Why are `unittest` and `asyncio` imported? Neither of those are explicitly referenced anywhere in the codebase. `sympy.utilities.decorator` imports `sympy.testing.runtests`, which imports `doctest`, which imports `unittest`, which imports `asyncio`. This...

There is the https://github.com/mnmelo/lazy_import which has a `lazy_callable` that provides functionality similar to the `lazy_function` in this PR. The package has received no new commits since 2018, so I decided...

For performance I inlined the function lookup in `__call__`. For a very simple function the `lazy_function` overhead goes down from ``` 237 ns ± 5.31 ns per loop (mean ±...

> Both test failures seem to be unrelated. @oscarbenjamin I rebased, but there are still two tests failing. It seems related to a recent change in aesara where `aesara.tensor.abs_` is...