Eemeli Aro

Results 571 comments of Eemeli Aro

Not mentioned in the original as back then markup was not a thing, but now that it isn't, we should indeed include a way to define markup in the schema/registry....

It determines whether to wrap placeholders with FSI/PDI bidirectional isolation marks, here: https://github.com/projectfluent/python-fluent/blob/df5ef402be3cf61f4a16e54e490e37e9cf276c05/fluent.runtime/fluent/runtime/resolver.py#L193-L195 The option is documented at the very bottom of the [Internals of fluent.runtime](https://github.com/projectfluent/python-fluent/blob/main/fluent.runtime/docs/internals.rst) document.

This one's tricky, because for YAML 1.1 `!!timestamp` has a rather explicit definition: https://yaml.org/type/timestamp.html Could it be that you're attempting to parse serialized timestamps without overriding the YAML version from...

Ok, so a couple of things are wrong here: 1. The test regexp indeed does not match the spec exactly, as it allows single-digit minutes and seconds, does not allow...

As far as I can tell, the only features that the current test regexp does not support and the one in the spec does are: 1. Seconds ending in a...

> Looking at the codebase, it seems to me that custom tags use `default: true` to know if they should emit an explicit tag. Since we need to conditionalize this...

I think this is finally actually ready for review. I needed to account for some Fluent changes due to mozilla/moz-l10n#83, and clean up some of the Locale utility methods --...

@mathjazz I'm not certain, but should we revert the changes made in #3615 once this lands?

Feh, this is indeed due to the changes in #3611, via a sequence that I'd not accounted for. The intent with this code https://github.com/mozilla/pontoon/blob/135da2111108b4a4e12ee2fe6917315400ed2cbf/pontoon/sync/formats/__init__.py#L54-L58 is that thanks to the `android_ascii_spaces`...

> Instead, we converted unescaped non-breaking spaces to normal spaces, effectively changing the translation? Sort of. We changed the translation in Pontoon, while not changing how the translation showed up...