eellison

Do you have any numbers on the update ?

@pytorchbot merge

@pytorchbot rebase

frontend related error cc @gmagogsfm

Cool! Yea most of the work has been done here. I have an example of running a decomposition in C++ [here]( https://github.com/pytorch/pytorch/pull/74186/files#diff-7b6bf72c68b81cf2f9749aa83ffd22e4b784917d4960a39ae8b704f45b369cc6R2959), with the decomposition defined [here](https://github.com/pytorch/pytorch/blob/master/torch/jit/_decompositions.py#L93). I'm going to...

How are they magic? IMO they are commonly used pattern with a clear syntactic meaning.

I think this boils down to a question of false positives versus false negatives. What should be the base assumption: that decorators have side effects or that they don’t. It...

The arguments about syntax & the ignoring side effects seem out of line with pyflakes stated design philosophy: `Pyflakes makes a simple promise: it will never complain about style, and...

``` @decorator fun(): ... ``` is exactly the same as: ``` fun(): ... fun = decorator(fun) ``` These are 1-1 mappings with exactly equivalent semantics. Functions are objects in python...

> pyflakes has no options and I don't think that's going to change this would just be a different category of Error that you could ignore.