Edwin Smith

Results 9 comments of Edwin Smith

Did you run hhvm with -vEval.Jit=1? Also, the main loop of the benchmark is in the php toplevel file, so we wouldn't JIT-compile it anyway. if you wrap the main...

* private methods in traits are only copied into using classes if the class doesn't have one. effectively this means a class can override a trait private method. * every...

> private methods in traits are only copied into using classes if the class doesn't have one. HH typechecks this with override semantics - C's concrete method must have a...

`__CLASS__` in a trait is rewritten to the class using the trait.

IIUC, both ExampleOne and ExampleTwo end up identical -- they both have the same bases, interfaces, and methods, correct? That said, I agree there is value to only allowing ExampleOne...

just to verify, your last try was with -vEval.EnableGC=1, correct?

Oh, also, the current GC scheduling heuristic is based on a fraction of the heap limit, which makes sense for production scenarios with small heap limits, but nowhere else. You...

I'd say 3.15 or master; the heuristic hasn't changed in a couple weeks but not sure how old 3.14 is, like @Orvid said.

I'll take a look at this, tho I might not have much to report until next week. @aorenste if you peek in scuba you should see collection stats from your...