Edwin Jose George

Results 19 comments of Edwin Jose George

Hi @krrishdholakia Thanks for the quick response ❤️ . Upon cloning the repository, I found that there was no mention of `pre-commit` as a guide but I found the config...

closing as outdated

@krrishdholakia Seems like this issue is already fixed and ready to be closed

It seems this error is similar to https://github.com/BerriAI/litellm/issues/3820 @gitwittidbit can you verify if this issue is still occurring? else we can close this issue

I have added type annotation to `tests` directory and would love to expand it to the rest of the project. Would love to hear feedbacks. Does this align with the...

I was trying to update type annotation on some part of the project, and made some of the observations - Type annotation can be made at lot of file =>...

My biased opinion (from my exp with previous projects) would be to follow with inline type annotation and restricting dict to pydantic. Something like, we could have a abstract class...

I think we can start type annotation to `litellm\llms\bedrock.py` and its calls? The file currently have 1000+ line with multiple classes. Or I could initially fix mypy typing errors, so...

Closing this PR as there are a lot of changes with main such that they have become difficult to read/review. One possible (but looong way) is to ensure locally that...

Hi @ishaan-jaff @krrishdholakia Does this PR align with the fix needed for https://github.com/BerriAI/litellm/issues/825 ? A typed dict was created with refernce to the Open ai spec. Or should get and...