Edouard Vincent

Results 30 comments of Edouard Vincent

I guess https://github.com/yarnpkg/yarn/pull/3361 would explain that...

Relevant discussion for `npm`: https://github.com/npm/rfcs/pull/397, but doesn't seem to go anywhere... Brainstorming on next steps/fixes - happy to hear thoughts/other ideas: * After installing vscode, before doing the release, force...

No, I haven't forgotten about this/you folks ❤️ life got in the way... I'm back trying to fix this, sent a new approach PR (which gets a bit easier thanks...

FYI - opened https://github.com/npm/cli/issues/5325 to track that nasty bug about the shrinkwrap file not being respected. I'll still continue with the PR here (need to clean-up some of the code/options,...

Ok... This is what it looks like when doing it from the release script... Which is indeed where it's needed, as the tgz we use to publish are the artifacts...

Anytime! I like giving back to the community too, especially for stuff I use daily! Plus I got to learn a LOT about NPM's dependency management, which I enjoyed. And...

Also, whilst confirming the fix of https://github.com/coder/code-server/issues/5174#event-7234295102, realized that the bug https://github.com/npm/cli/issues/5325 is actually less of an issue here - because it doesn't seem to be buggy when installing it...

Confirmed locally with the artifacts from https://github.com/coder/code-server/pull/5071 that code-server can be installed (again) with `npm`. Currently it will be in the same state as when using `yarn` (due to https://github.com/npm/cli/issues/5325):...

Seems to install all good as expected now :D ``` ubuntu@ip-172-26-6-151:~$ npm install -g --unsafe-perm [email protected] added 211 packages, and audited 212 packages in 1m 12 packages are looking for...

And as a good news, the bug from https://github.com/npm/cli/issues/5325 doesn't seem to affect remote installs (I obviously was only testing with local packages), so the `npm` install is fully deterministic....