Edouard Vincent

Results 30 comments of Edouard Vincent

So the failure seems to be because of some dependencies missing in the `node_modules` from the original install... Which my guess is because something is failing to be installed. Will...

Ok new tentative out, with: 1. Using `npm` or `yarn`, depending on what was initially used. 1. Generating the shrinkwraps when generating the release, rather than initially. 1. Removing `@parcel/node-addon-api`...

FWIW, I'm playing around in https://github.com/edvincent/code-server/pull/1#partial-pull-merging to be able to run the CI/CD and pinpoint some of the culprits. To avoid the flood and needing approvals for the workflows to...

Ok, I think I got it this time! Moved to generate the shrinkwraps in the `release:standalone` command, which basically allows not having to know which `package.json` is being copied etc......

Yep.. We need the `node_modules` to be populated to be able to generate the shrinkwrap file... The other solution would be to still do it in `build-release.sh`, which means we'd...

Today there is never a `yarn` in `build-release.sh` - so a `yarn --production` won't be removing files, but also installing stuff that was never installed. The only `yarn` that gets...

Damn it's actually a bit more nuanced than just removing the `KEEP_MODULES` behavior... If we run `yarn --production`, it would also install some of the things we were excluding in...

Damn completely missed this.. I think I had something weird happening in my local dev box, and I was under the impression the upper-most one would take care of the...

Ha no, the root-cause for missing this was that I validated the other change by using the `package.tar.gz` generated from the CI/the yarn command... which actually doesn't strip the `yarn.lock`...

> I wonder why it works with `yarn` and not `npm` Because `yarn` doesn't respect ANY lockfiles when installing something globally (and anyway when running `yarn publish`, files like `yarn.lock`...