Edouard Vincent

Results 30 comments of Edouard Vincent

Correct - I'm all for the most lightweight install for the basic features, so not forcing `libsecret` is a bit better. Ideally `vscode` would do the `optionalDependency` upstream, but I'm...

That's the one where I was suggesting to use `npm ci` right? Happy to have a look yup, was already in my to-do from https://github.com/coder/code-server/pull/5071#discussion_r950597128 As a side-comment, that error...

Oh nvm, you mean actually use `npm run` to run the tests etc...? Because I think you already merged the one to install it with `npm`?

So, I don't think we should do that? I think the line between `yarn` and `npm` should be development of code-server vs install of code-server itself. Or in other words,...

> I do agree we should have the distinction. It would be nice if we used one instead of mixed them though. I wonder if instead we should move development...

> @edvincent any insight here since you're the npm expert? 🤓😬😂 Are all of the installs using ARM & Windows? I don't have my RPi handy until this evening so...

Ok able to reproduce on Ubuntu 22.04 on an ARM instance. Seems a problem with the underlying dependencies of `lib/vscode`, specifically `xterm`... Which I would have expected the shrinkwrap file...

A short term hack/workaround: after the global install, go to the `node_modules/code-server/lib/vscode` directory directly and issue an `npm install --legacy-peer-deps`.

I suspect it's an issue with how the combo `npm` + `semver` computes `peerDependencies`... * `[email protected]` declares `"xterm": "^4.0.0"` as a peer dependency - [see package.json](https://unpkg.com/browse/[email protected]/package.json) * Our lockfile is...

``` > semver.satisfies('4.20.0', '^4.19.0') true > semver.satisfies('4.20.0-beta.20', '^4.19.0') false > semver.satisfies('4.20.0-beta.20', '^4.19.0', {includePrerelease: true}) true ``` And the explanation is the same that from https://github.com/coder/code-server/pull/4918 and comes in https://github.com/npm/node-semver#prerelease-tags: pre-release...