Erik Duveblad

Results 3 comments of Erik Duveblad

Yeah, this is a minefield 😨 I can't say that your change is obviously correct, but at least the existing tests and your new test is passing and the newly...

Hey @erikj79, nice work 🎉 First of all, I think your changes are fine, the reasoning and the code checks out. I have a bunch of suggestions, but those you...

I don't really mind the static method, in general I prefer that over an abstract base class. I personally think that an abstract base class makes it so much harder...