Eduardo Blancas

Results 297 comments of Eduardo Blancas

Sure, thanks! I'm thinking of some pytest fixture that uses the autouse flag, and checks if we're in a non-tmp directory (I think we can check this by checking if...

So right now, we don't store pipeline run metadata, so it isn't possible to recover this. Although I think this could be useful for many use cases. Perhaps we could...

re pre-commit: yes, we have an optional [pre-commit hook](https://github.com/ploomber/ploomber/blob/master/.githooks/pre-push), but it only checks flake8, it doesn't apply yapf. if you're up for the challenge, PRs are welcome :) re initialization,...

> I can now also work on checking that `source`, `product`, `name` and `dag` do not appear in `task_defaults[class_]`. How would you recommend this be handled if they do appear?...

hi @jramirez857, thanks for the patience, the changes look good. can you fix the tests? I saw the logs and noticed this error: ``` > init_params = {**task_defaults[class_], **task_dict} E...

[this blog post](https://ploomber.io/blog/open-source/) will be handy for debugging the failing tests - check the "coding!" section, it shows how to debug tests

the default `None` is fine, what we need to cover is this error: ``` > init_params = {**task_defaults[class_], **task_dict} E TypeError: 'NoneType' object is not subscriptable ``` so here task_defaults...

awesome, thanks for the update! I see that some of the `test_cloud.py` fail, this is because of some misconfiguration on our end, so there's no need for you to debug...

I think the problem is that the user is submitting a dictionary with strings as keys (in your case `NotebookRunner`, but you're passing the class object). You can get the...

> Looking back at the previous comments you mentioned I should cover a couple scenarios. the test cases look right > Where can I get a good idea of how...