Eduardo Blancas

Results 295 comments of Eduardo Blancas

done, license file deleted! @carterbox

(I edited my original comment to make it clearer) > Just to clarify but is the issue that since the change for df occurs within a function when the code...

good point. maybe we should have an option and let the user decide? I cannot think of a good heuristic

yeah, I did that as an easy way to ensure that the products and tasks are unique, since ploomber does not allow duplicates. but it'd be better to only add...

please open a PR with your changes, that will help me evaluate the solution

thanks for the patience! can you push a new commit to re-trigger the CI for your PR? https://github.com/ploomber/soorgeon/pull/87 ``` git commit --allow-empty -m "trigger ci" ```

apologies for the delay @rrhg; I'll review this in the next 1-2 days. thanks for your patience and for your contributions!

I changed the title since it wasn't accurate. this isn't about all types of global variables. but about variables defined in the notebook that do not support serialization. A typical...

so this is a replacement of https://github.com/ploomber/ploomber/pull/988, right?

closing this in favor of https://github.com/ploomber/ploomber/pull/1028