Eduard Bagdasaryan

> split in two or three parts I separated the first part as [PR756](https://github.com/squid-cache/squid/pull/756).

> why Optional is necessary here You are right that we could reach the same goal with the default constructed Ip::Address object (it lacks isEmpty(), though) but in this case...

> Please separate the flags refactoring from the interception refactoring from the PROXY protocol addition I separated all the refactoring required for the new feature in a dedicated [PR835.](https://github.com/squid-cache/squid/pull/835) >...

> it is existing, working code rather than something that still needs to be designed and written You are right, initially, this PR832 encompassed all the required changes. After discussing...

Since there are not open change requests here - I think we shoud remove S-waiting-for-author until we discuss/agree on possible solution(s).

> Perhaps we should add S-waiting-for-prerequisite? Or an even more general S-waiting-for-other IMO both 'prerequisite' and 'other' are quite general - e.g., 'reviewer' can fall into these categories. I would...