Eduardo Silva Pereira

Results 454 comments of Eduardo Silva Pereira

we got an internal report that this specific approach would not work in the latest 1.8.x series (not sure "why"). We are submitting another PR that proposes a similar solution...

@LACrea thanks for the report, we will make sure to update the code (cc: @leonardo-albertovich )

@leonardo-albertovich what's the specific requirement/use case to solve ?

@pwhelan pls check on DCO and other CI issues

while this looks like a good PR, 3.1 is pretty much getting small fixes for long-term stabilization. Since the functionality is already in GIT master (next v3.2) I will proceed...

thanks @yongtang ! a few requirements, would you please split the commits per components ?, e.g: - build: ...everything on any cmake file... - http_client: ... - upstream: ... -...

thanks for your contribution. In order to review it, please include a unit test for this change: ref: https://github.com/fluent/fluent-bit/blob/master/tests/internal/multiline.c#L1468

@cosmo0920 we don't do ulimit stuff in Fluent Bit, why should we do it for Windows ? (maybe we just need to update the docs for windows users ?)

thanks folks for the context. @cosmo0920 I suggest to rename this option to `windows.maxstdio`