fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

in_http: support for msgpack .

Open pwhelan opened this issue 1 year ago • 1 comments

Summary

This is a backport of #8499 to the v3.1 series.

Description

This patch adds support for msgpack payloads to the in_http plugin, which can be emitted by out_http and used to be the default format for it.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [ ] Example configuration file for the change
  • [ ] Debug log output from testing the change
  • [ ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ ] Run local packaging test showing all targets (including any new ones) build.
  • [ ] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ ] Documentation required for this feature

Backporting

  • [ ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

pwhelan avatar Sep 30 '24 14:09 pwhelan

@pwhelan pls check on DCO and other CI issues

edsiper avatar Oct 20 '24 19:10 edsiper

The DCO issues continue to be problems from previous commits:

  • Commit sha: 129748f, Author: edsiper, Committer: Eduardo Silva; Expected "edsiper [email protected]", but got "github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
  • Commit sha: 507d975, Author: Leonardo Alminana, Committer: Leonardo Alminana; The sign-off is missing.
  • Commit sha: 7f20490, Author: leonardo-albertovich, Committer: GitHub; Expected "leonardo-albertovich [email protected]", but got "Leonardo Alminana [email protected]

To fix them would require me to rewrite the git history.

pwhelan avatar Oct 21 '24 13:10 pwhelan

while this looks like a good PR, 3.1 is pretty much getting small fixes for long-term stabilization. Since the functionality is already in GIT master (next v3.2) I will proceed to close the PR.

edsiper avatar Nov 07 '24 20:11 edsiper