Édouard Lopez

Results 146 comments of Édouard Lopez

Hello, any update on the MFA recovery?

I updated the test with a [tautology](https://en.wikipedia.org/wiki/Tautology_(logic)). The invalid file should be considered a failed test, so the pipeline doesn't succeed. Below, I highlighted the output changes ```diff ❯ source...

The `@test` is not important, but an invalid file should trigger a failed exit code so pipeline jobs fails too and are visible as such.

You can check out the result of `fishtape tests/invalid.fish` with the current Fishtape version, it's not failing.

Yep, it's on purpose, so the file is invalid in Fish and it triggers a parsing error. Previously, Fishtape didn't increment the `_fishtape_test_failed` variable in such case and thus resulted...

Thanks for the great work, I have a Lenovo X1 Carbon Gen 5 with this device and use a Linux Mint Vera 21.1 ~ Ubuntu jammy

It has been [merged in `3.2.0`](https://github.com/fish-shell/fish-shell/pull/7596) :tada:

I get screenshots on Firefox and no error. cc @cburgmer