containers-theme icon indicating copy to clipboard operation
containers-theme copied to clipboard

Published 20 hours ago • verified publisher icon jonathanKingston

bugfix: get default containers to return to default theme color

Open denisenadal opened this issue 4 years ago • 13 comments

passing in the tab.windowID to the resetTheme function as well as removing the hasUnpainted check and replacing it with an else statement seemed to do the trick.

I mostly figured this out by just poking around and looking at the docs for browser.theme.reset, so I'm not 100% sure WHY these changes work ..

denisenadal avatar Mar 21 '20 00:03 denisenadal

@jonathanKingston Hi! I've loaded the patched version in Nightly, and observed no issues. There is more discussion in #12.

Any chance you'll have a few minutes to merge and push the new version to AMO?

Thanks!

hwine avatar Mar 25 '20 20:03 hwine

Would love to see this PR merged :v:

edouard-lopez avatar Jun 07 '20 12:06 edouard-lopez

Sorry for the delay here, I turned off notifications. I'll merge and release this at lunch. The code seems great... I'm pretty sure it's just removing an ex workaround to a bug in firefox. :)

jonathanKingston avatar Jun 08 '20 09:06 jonathanKingston

@jonathanKingston ping :heart:

edouard-lopez avatar Jun 29 '20 11:06 edouard-lopez

@jonathanKingston ping again -- hoping you have re-enabled notifications.

hwine avatar Mar 11 '21 22:03 hwine

@jonathanKingston ping ❤

T00mm avatar Jun 29 '21 11:06 T00mm

Hi! I need to contact Mozilla as it appears their new oAuth unification has locked out my Addons account as it appears I had multiple with the same email. Will update once I hear back.

jonathanKingston avatar Jun 29 '21 13:06 jonathanKingston

Hi @jonathanKingston,

I hope you are doing well, and you could get your issues with Mozilla resolved. Is there anything we can help with to get this merged and released?

klaustopher avatar Jan 28 '22 12:01 klaustopher

@hwine, would you please accept to share the patched version somehow before the change being merged by @jonathanKingston?

I really enjoy this extension and find it very sad that the bug correction is not merged.

florck avatar Feb 23 '22 14:02 florck

@hwine, would you please accept to share the patched version somehow before the change being merged by

You can clone the PR and build the XPI locally, then install in Firefox (after every restart). I just commented on #12 & this PR -- I don't know JS well enough to support a fork and publish-to-amo. (I am not the author of the PR.)

I really enjoy this extension and find it very sad that the bug correction is not merged.

me, too!

hwine avatar Feb 23 '22 16:02 hwine

Hi @jonathanKingston, any progress with Mozilla?

T00mm avatar Apr 29 '22 07:04 T00mm

I've chatted with a few former colleagues and eventually found the right team to email; no response as of yet.

jonathanKingston avatar May 01 '22 15:05 jonathanKingston

Hi, any update on this issue?

T00mm avatar Jun 08 '23 09:06 T00mm

Submitted for review, thanks for your help and sorry for the 4 year turnaround here (I finally got access)

jonathanKingston avatar Jun 14 '24 01:06 jonathanKingston