Edward Oakes
Edward Oakes
please fix plural nit then LGTM
@dmatrix please take a look when you have a chance. Pretty much just code changes.
Thanks @stephanie-wang! @simon-mo, the DCO build is failing.
Will do a pass after @dmatrix's comments are addressed
@shrekris-anyscale one more lint failure, then LGTM to merge https://buildkite.com/ray-project/ray-builders-pr/builds/42455#01828a00-5adb-45fc-94f2-7e0775be22c6/9184-9514
Will do a pass after @dmatrix's comments are addressed
@simon-mo you need codeowner approval from someone here
Thanks for the comments @shrekris-anyscale, I addressed the nits and will do a deeper pass for the other comments next.
Thanks for the review @stephanie-wang I will try to address the feedback today. Going to be driving most of the afternoon so might not have it re-reviewable until Monday. About...
@stephanie-wang comments are addressed, please take another look.