Edmundo Ruiz Ghanem

Results 32 comments of Edmundo Ruiz Ghanem

Oh, I see that it has changed quite a bit in master. I was looking at the last tag (0.8) because it's the one I'm using: https://github.com/robertpenner/as3-signals/blob/v0.8/src/org/osflash/signals/Signal.as#L26 I was running...

@joelpickup In whichever test framework you're using in the initialization JS file, or via an import in your test, you can add the following: ```js const React = require('react-native'); React.I18nManager...

@lmossman would it be possible to add storybooks for the areas impacted?

Two things I noticed while testing that need to be addressed: Something is off when expanding the log, the height of the component resizes https://user-images.githubusercontent.com/168664/189740534-04bca12a-f982-4bcf-877f-5f1f65b42dc7.mov When there is an error...

@YatsukBogdan1 > Not sure how to handle this case, in figma, there was no case where we have reset streams, and also a failure. Should we not show reset stream...

Another thing I noticed while testing, looks like the style of pending/running text broke: ![image](https://user-images.githubusercontent.com/168664/190180461-5a09d251-15c8-4327-844e-800ef960ca83.png)

Things are looking a lot better, but I noticed this during testing: Because a line was removed from the in-progress status, the height is smaller than the rest of the...

Discussed in planning - @lmossman will take over to merge and close this issue while @ambirdsall is on PTO

Replaced by #15109 - Tested after merge and fixes the issue.

@evantahler The style issues are always easy to fix. I highlighted a few areas in the comments that point out potential logic issues.