Eugene Ma

San Francisco, CA

Results 8 comments of


                                            Eugene Ma

Conflict between Record and IPersistentMap

Thanks for the bug report. I'll have a look sometime this week.

[prometheusremotewriteexporter] reduce allocations when serializing protobufs

sorry for the staleness, I'd still like to get this PR merged (was busy with work). I will provide a benchmark to get this PR moving along

[prometheusremotewriteexporter] reduce allocations when serializing protobufs

@ArthurSens thank you for the benchmark! I'll get on it this week. `sync.Pool` is relatively new to me too, and seemed like a good fit for this code.

[prometheusremotewriteexporter] reduce allocations when serializing protobufs

@ArthurSens added the benchmark, PTAL!

deltatocumulativeprocessor: enforce max bucket count for exphistograms

@RichieSams @jpkrohling do we need additional reviews for this PR?

deltatocumulativeprocessor: enforce max bucket count for exphistograms

cc @sh0rez

deltatocumulativeprocessor: enforce max bucket count for exphistograms

@sh0rez thanks for the review! apologies on my delayed response as well

deltatocumulativeprocessor: enforce max bucket count for exphistograms

@sh0rez do you mind taking another look at this PR when you have a chance, thanks!