edison comments

Results 401 comments of


                                            edison

fix(hydration): avoid mismatch during hydrate text with newlines in interpolation

> Any reason not to include test cases for the change to `hydration.ts`? It seems that `jsdom's innerHTML` does not normalize `\r\n` into `\n`. I did not figure out a...

fix(hydration): avoid mismatch during hydrate text with newlines in interpolation

> > > Any reason not to include test cases for the change to `hydration.ts`? > > > > > > It seems that `jsdom's innerHTML` does not normalize `\r\n`...

feat: add support for Popover API

Thank you for your contribution. Maybe we should review https://github.com/vuejs/core/pull/10977 first. If the author is no longer active, we can consider creating a new PR.

Edge Case: Directives in v-if with specific key (1) will not trigger mounted hook in v-else case with a diffrent Directive.

`v-if` and `v-else` automatically generate a key. By adding `:key="1"` to v-if, both `v-if` and `v-else` end up with the same key of 1, which affects the patch logic.

fix(runtime-core): properly diff slot node and fallback node

/ecosystem-ci run

fix(runtime-core): properly diff slot node and fallback node

/ecosystem-ci run

Allow disabling or clearing of compile cache in SSR render

I don’t think this is a complex feature, and perhaps there’s no need to go through an RFC for discussion. I prefer `Option 2` and made a PR, see #12868.

feat(effectScope): add lazy-initialized `signal` getter with automatic abort on stop

LGTM Similar PR https://github.com/vuejs/core/pull/10826

refactor(compiler-vapor): skip unnecessary attribute quoting in templates

Thanks for your PR, it looks great. I think it should add some runtime tests in `dom/template.spec.ts` to verify these changes work as expected.

"Hydration completed but contains mismatches" error not caught by the Vue error handler

You can enable [VUE_PROD_HYDRATION_MISMATCH_DETAILS](https://vuejs.org/api/compile-time-flags.html#VUE_PROD_HYDRATION_MISMATCH_DETAILS) to display details in the production build.