edison comments

Results 401 comments of


                                            edison

fix(reactivity): unexpected behaviors for adding integer prop out of valid array length on array

a side note: it's a real edge case, IMO, this change is not worth it.

fix(runtime-core): directives should be handled correctly with fragment

@linzhe141 It seems that https://github.com/vuejs/core/pull/5428 is not the proper fix for both #11900 and #5407. Could you give it a try to fix #5407?

fix(runtime-core): directives should be handled correctly with fragment

@hengistchan Probably not. It's an edge case, removing the comment node will work.

docs(api): add warnRecursiveComputed config option

> @edison1105 looks good to me! Should we merge the docs before or after the core PR is merged? I think we need to wait for the core PR to...

feat(custom-element): allow specifying additional options for `shadowRoot` in custom elements

Thanks @padcom LGTM !

feat(custom-element): allow specifying additional options for `shadowRoot` in custom elements

LGTM~ Maybe we can use vitest's browser mode for testing, but it's an experimental feature for now. [vitest.dev/guide/browser#configuration](https://vitest.dev/guide/browser/#configuration)

feat(custom-element): allow specifying additional options for `shadowRoot` in custom elements

@padcom First of all, thank you very much for your PR. We have reviewed this PR and it looks good. However, since it adds a `shadowRootOptions` parameter, we're considering releasing...

feat(custom-element): allow specifying additional options for `shadowRoot` in custom elements

@padcom The exact timing hasn't been determined yet, but I'll keep an eye on this PR to ensure it gets merged.

feat(custom-element): allow specifying additional options for `shadowRoot` in custom elements

Strictly speaking, this PR should be considered a feature, but since it's relatively simple, We plan to merge it into the next patch version. However, this change requires updating the...

feat(compiler): recover parser from incomplete open tag

Closing as stale.