fix(runtime-core): directives should be handled correctly with fragment
close https://github.com/vuejs/core/issues/5407
Size Report
Bundles
| File | Size | Gzip | Brotli |
|---|---|---|---|
| runtime-dom.global.prod.js | 100 kB (+51 B) | 37.8 kB (+32 B) | 34 kB (+18 B) |
| vue.global.prod.js | 159 kB (+51 B) | 57.7 kB (+22 B) | 51.3 kB (-21 B) |
Usages
| Name | Size | Gzip | Brotli |
|---|---|---|---|
| createApp (CAPI only) | 49 kB (+209 B) | 18.9 kB (+67 B) | 17.2 kB (+1 B) |
| createApp | 55.5 kB (+209 B) | 21.3 kB (+69 B) | 19.4 kB (+19 B) |
| createSSRApp | 59.5 kB (+209 B) | 23 kB (+62 B) | 21 kB (+99 B) |
| defineCustomElement | 60.2 kB (+209 B) | 22.9 kB (+84 B) | 20.8 kB (+100 B) |
| overall | 69.1 kB (+51 B) | 26.3 kB (+12 B) | 24 kB (+62 B) |
@vue/compiler-core
pnpm add https://pkg.pr.new/@vue/compiler-core@11902
@vue/compiler-dom
pnpm add https://pkg.pr.new/@vue/compiler-dom@11902
@vue/compiler-sfc
pnpm add https://pkg.pr.new/@vue/compiler-sfc@11902
@vue/compiler-ssr
pnpm add https://pkg.pr.new/@vue/compiler-ssr@11902
@vue/runtime-core
pnpm add https://pkg.pr.new/@vue/runtime-core@11902
@vue/runtime-dom
pnpm add https://pkg.pr.new/@vue/runtime-dom@11902
@vue/reactivity
pnpm add https://pkg.pr.new/@vue/reactivity@11902
@vue/server-renderer
pnpm add https://pkg.pr.new/@vue/server-renderer@11902
@vue/shared
pnpm add https://pkg.pr.new/@vue/shared@11902
@vue/compat
pnpm add https://pkg.pr.new/@vue/compat@11902
vue
pnpm add https://pkg.pr.new/vue@11902
commit: 6bcb45f
@linzhe141 It seems that https://github.com/vuejs/core/pull/5428 is not the proper fix for both #11900 and #5407. Could you give it a try to fix #5407?
It seems that #5428 is not the proper fix for both #11900 and #5407. Could you give it a try to fix #5407?
yes, i will
@linzhe141 can also update 3.4.x? same problem occurs in 3.4.x
@linzhe141 can also update 3.4.x? same problem occurs in 3.4.x还可以更新3.4.x吗?同样的问题出现在3.4.x中
I think there might be some problems with the current fix, and I'll need to look into it more deeply.
@hengistchan Probably not. It's an edge case, removing the comment node will work.