EdgarsN

Results 6 comments of EdgarsN

Thanks everyone for temporary workarounds. Imo, this should be fixed in 1.0 anyways. I think no one doesn't care what's coming up in 2.0 since it's a future version, not...

> @edgarsn I'm afraid I don't agree with your statement that this should be fixed in 1.0. This is an open source project, and we can't expect open source maintainers...

I'm on vacation in an hour, so no PR from me for now. But here are tests - https://github.com/edgarsn/graphql-laravel/commit/471a949d40d0002c9f7a814e8ae57f49cf12c299 `test_customQueryDoesntWorkWhenQueryUsingUnionType` - failing example. It should return only 1 comment to...

> I don't think I'm capable of making fix for this. I can only make a draft PR with tests showing the bug, but it wouldn't help you a lot...

> > I can only make a draft PR with tests showing the bug, but it wouldn't help you a lot I guess. > > Au contraire! It would still...

I suggest you to add [codecov](https://about.codecov.io/for/open-source/) to github actions, so that it's easier to track the coverage in PR's.