Edgar Costa comments

Results 91 comments of


                                            Edgar Costa

Fix docstring for fmpz_poly_is_squarefree

@fredrik-johansson would it be okay to change the definition of square free?

Definition of irreducibility

I would say that units are not irreducible. For these kinds of things lately, I am a great fan of looking at what mathlib says, https://leanprover-community.github.io/mathlib4_docs/Mathlib/Algebra/Prime/Defs.html#Irreducible, as they need to...

Add a ``FLINT_ASSERT_ALWAYS`` macro

You could also have asserts with different levels. `ASSERT`, `ASSERT1`, etc.. Ordered from cheap/important to expensive/stringent

New ray class

Overall it looks okay. There is a bunch of commented code that could be removed. I would also suggest add more tests, in particular some harder tests.

Use `clang-format` in a CI job

We also discussed this in the last workshop, but I didn't get into it

use doxygen

Can someone point me to some the advantages of doxygen? (I am just curious, I am sure @alexjbest told me a about them, but I have forgotten)

`₃F₂(-10, 11, -10; 1, -10; 1)` returns nan

I do not think that `arb_hypgeom_pfq` should be automatically canceling pairs. That is a function with a single purpose; the user has the freedom to call it as they wish,...

abs2 and/or hypot2 functions

I fixed your links. abs2 is trivial once one has hypot2 https://github.com/flintlib/flint/blob/9e0d010b96b58ecbb088083f595f8dc75e056d80/src/acb.h#L449-L452 and for hypot2 we just need to remove: https://github.com/flintlib/flint/blob/9e0d010b96b58ecbb088083f595f8dc75e056d80/src/arb/hypot.c#L33

VimR window opens but does not accept any keyboard input (macOS 15.5, Neovim 0.11.3)

This seems to be the same issue as #1120 and #1122.

`fmpz_poly_is_squarefree` wrong results?

That or just say it doesn't double roots over the complex numbers