Fix docstring for fmpz_poly_is_squarefree

Open albinahlback opened this issue 1 year ago • 7 comments

Solves #2084

@fingolfin

Oct 15 '24 11:10 albinahlback

@edgarcosta please make a suggestion here if you want one

Oct 15 '24 14:10 albinahlback

I honestly find it confusing that the polynomial zero is square-free, but perhaps a change in the code now is too late.

Oct 15 '24 14:10 edgarcosta

I don't know. If people have a problem with it, I'm down for changing it.

Oct 15 '24 14:10 albinahlback

@fredrik-johansson would it be okay to change the definition of square free?

Oct 15 '24 15:10 edgarcosta

I'd be happy with 0 being considered not squarefree.

Oct 15 '24 15:10 fredrik-johansson

FWIW we came to the same conclusion for Nemo, see https://github.com/Nemocas/Nemo.jl/issues/1510

Oct 15 '24 17:10 thofma

Seems like a reasonable fix before releasing 3.2.0. However, we would have to make sure that this is consistent throughout FLINT. Moreover, it seems like some docstring do not provide the definition of square-free (see docstring for fq_poly_is_squarefree).

Oct 15 '24 17:10 albinahlback