Eden Federman

Results 64 comments of Eden Federman

I think we can take inspiration from the Java auto instrumentation. The javaagent automatic instrumentation [allows users to add additional spans](https://opentelemetry.io/docs/instrumentation/java/automatic/annotations/) via the `@WithSpan` annotation. This is a similar approach...

Is this feature implemented in other auto instrumentations as well? If I remember correctly, Java/NodeJS auto instrumentations generate spans for Kafka/databases by default even though the semantic conventions are not...

> @edeNFed would it be helpful to expose this as an option as well? Something like `WithAllInstrumentation`? > > > > That way any distribution of this project could make...

I will take a look at this, hopefully this week.

Copying my comment from the original thread: > > The default size is 1024 bytes, which may not be enough for all eBPF programs. > This sets the size of...

I like this idea, I only have one question: how would you deal with new Go versions that come out? Will we need to update the build for every new...

Yes, but then it will generate offsets only for the standard library of that specific Go version. The automatic instrumentation may be compiled with a different Go version than the...

Currently the agent works as follows: 1. Find the target process 2. Detect compiled go version + versions of other libraries (this data is left by the go linker and...