opentelemetry-go-instrumentation icon indicating copy to clipboard operation
opentelemetry-go-instrumentation copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Review LogSize configuration

Open MikeGoldsmith opened this issue 2 years ago • 1 comments

Review hardcoded logsize and whether we should allow users to adjust via configuration.

Originally posted by @MikeGoldsmith in https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/128#pullrequestreview-1409363569

MikeGoldsmith avatar May 03 '23 11:05 MikeGoldsmith

Copying my comment from the original thread:

The default size is 1024 bytes, which may not be enough for all eBPF programs. This sets the size of the requested buffer allocated from the kernel when loading eBPF programs. Allowing users to control it may have some security concerns (for example, setting a really high value causing huge memory allocation)

edeNFed avatar May 03 '23 11:05 edeNFed