Charles-Edouard Brétéché

Results 310 comments of Charles-Edouard Brétéché

@stevekuznetsov see https://github.com/kubernetes/test-infra/pull/27018

Thanks @stevekuznetsov !

> I'm also for completely removing conditions and upgrade pipeline to 0.37+. +1

@qaifshaikh are you trying to replace v1alpha1 with v1beta1 ? Or to support both ?

Why not support both alpha and beta ? Entirely removing alpha is going to break for existing users right ?

Supporting multiple versions makes sense to me. At some point we’ll need to support v1 too. Shouldn’t adding support for beta and keeping current alpha support be less work that...

Just my opinion, I think we should support multiple versions. IMHO we should have done it a long time ago. I feel like replacing alpha1 with beta1 is a bit...

It looks like https://github.com/kubernetes/test-infra/blob/aa928caf31ab0f30c2c999b2543790fbfa08e095/prow/test/integration/test/pod-utils_test.go#L557 fails, but i don't know how to get the why. Pure guessing, the pipeline is not valid and the pod never gets created ? How is...

@qaifshaikh all green now. I will try to review later today.

I don’t have approver permissions :(