test-infra icon indicating copy to clipboard operation
test-infra copied to clipboard

feat: add tekton v1beta1 client

Open eddycharly opened this issue 1 year ago • 7 comments

This PR adds tekton v1beta1 client.

eddycharly avatar Aug 04 '22 12:08 eddycharly

@alvaroaleman this adds support for generating tekton client v1beta1. I'd like to give a try to supporting both v1alpha1 and v1beta1 side by side.

eddycharly avatar Aug 04 '22 13:08 eddycharly

/test pull-test-infra-integration

eddycharly avatar Aug 04 '22 13:08 eddycharly

/test pull-test-infra-integration

eddycharly avatar Aug 04 '22 13:08 eddycharly

/test pull-test-infra-integration

eddycharly avatar Aug 04 '22 14:08 eddycharly

/assign @spiffxp

eddycharly avatar Aug 13 '22 14:08 eddycharly

@alvaroaleman can we merge this one ?

eddycharly avatar Aug 15 '22 23:08 eddycharly

Can we get some help to merge this @cjwagner?

qaifshaikh avatar Aug 17 '22 15:08 qaifshaikh

@spiffxp can you help out here?

qaifshaikh avatar Aug 26 '22 16:08 qaifshaikh

Sorry if I'm missing something, but why are we generating the tekton clients here (as opposed to importing them)?

stevekuznetsov avatar Aug 26 '22 16:08 stevekuznetsov

@stevekuznetsov see https://github.com/kubernetes/test-infra/pull/27018

eddycharly avatar Aug 26 '22 16:08 eddycharly

Ah, yes, now I remember. Thank you :)

/lgtm /approve

Let's get this in, then

stevekuznetsov avatar Aug 26 '22 17:08 stevekuznetsov

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eddycharly, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 26 '22 17:08 k8s-ci-robot

Thanks @stevekuznetsov !

eddycharly avatar Aug 26 '22 23:08 eddycharly