eddieh-xlnx
eddieh-xlnx
This PR has morphed beyond "Copying static net while copyImplementation" into one that also does HWCT. Can we separate the two again please?
@clavin-xlnx How should we move towards resolving this in light of https://github.com/Xilinx/RapidWright/pull/379?
Does the test here pass today?
Not sure if this is helpful, but could it be because https://github.com/Xilinx/RapidWright/blob/5aaa678493e56f069ca8e5d58a10b95196d4ef64/src/com/xilinx/rapidwright/design/DesignTools.java#L1835 is doing a "raw" setting of the cell type, without updating the port refs inside the `EDIFCellInst`'s portInsts?...
I remember we discussed this PR: whether it covers all cases, and whether it overlaps with functionality already present (but unmerged) in `sashimi`.
But what if a user uses `standalone_v1.jar` and then later uses `standalone_v2.jar` -- any new/updated files in v2 would not be unpacked, and a user would have to blow away...
Did #495 fix this? If so, we can close.
Would it be straightforward to generate a test for this?
> If we have a design that had the need, possibly yes. I was more alluding to -- do you recall what testcase you used to build this feature? I...
Main changes: * `GlobalSignalRouter.routeStaticNet()` clobbers the existing list of PIPs on static nets, so for partial routing move them out beforehand and combine them back after calling this method. *...