Dirk Eddelbuettel
Dirk Eddelbuettel
100% organic upstream and nuttin' I can do about it. I recommend local use of -Wno-parentheses Boost is now on GitHub under https://github.com/boostorg so you could check where the _current_...
And to be extra sure: you are seeing compiler warnings. correct? As far as I am never these have NEVER become a CRAN nag on the level of a NOTE...
Good question. Modules has not seen a lot of love those last few years. If your repo with added finalizer public? Not sure we have (m)any other examples of finalizers...
What do you think about e.g. rule of four adding the missing ones as defaults? (I am spitballing here...)
Do you want to give modifying the set of defaults and see where it leads you?
That's actually a pretty nice example for modules use!
Hey @ctoney just circling back and as you (per CRANberries) have a new version on CRAN: are you all good here? What if any action items do we have left?
You're the man. This has (implicitly) been on the TODO list for years ever since C++11 became the minimum compiler standard supported by R (in R 4.0.0 if I recall...
This PR is actually surgically precise and only extends the surfce. It really should have no implications (or so we hope ...). We can plan to go over the code...
Fair question. "Maybe". It's a little assymetric either way. And as long as we do accomodate pre-C++11 anyway does it hurt? I also wonder how that file got away with...