Ed Bennett

This is a good point. I think this addition would add 5, maximally 10 minutes to the episode, but that some of this would be compensated by less confusion around...

Ah yes, it makes sense that if none of the tests explicitly set `n_effective` then coverage will drop as a result of this change. I agree that that looks like...

In that case, does it seem better to remove it from `sample_initial()` but leave it in place (with a new test) in `sample()`, so that downstream code that uses `sample()`...

Thanks both; to summarise, what remains to be done is I think: - [x] a test for `Sampler.sample()` with `n_effective != np.inf` - [x] add a deprecation warning when `sample_initial()`...

I've added a `DeprecationWarning` to the following parameters, and mentioned the deprecation in the docstrings. * The `n_effective` parameter of `Sampler.run_nested` (default is `None`) * The `n_effective` parameter of `DynamicSampler.sample_initial()`...

All of the changes discussed above are now made (other than the `n_effective` parameter to `DynamicSampler.run_nested()`, which has been worked on relatively recently so I think behaves differently and is...

Thanks for your replies > My only thought now, is whether it's better for the user to still allow > staticnested.run_nested(n_effective=XXX), but instead of deprecation warning throw a RuntimeWarning saying...

Many thanks Sergey! > To be honest, we probably want to restructure this bit, i.e. completely get rid of this https://github.com/edbennett/dynesty/blob/4e0594eac0f2fdd224ab8b79dd348813a842e467/py/dynesty/sampler.py#L683 > but maybe I'm missing some usecases of static.sample(n_effective=X)...

Two more things that I have checked: * @LupoA pointed out that there is a normalisation factor of `HMC_MOMENTUM_DENOMINATOR` that is by default set to 2, while in HiRep this...

Some more testing shows that with a thermalised configuration (the same one for both codes), and controlling for all the factors above, the acceptances match much more closely between HiRep...