Salomon

Results 15 comments of Salomon

I looked into this, and I think a lot of them are actually from our version of pandas using an outdated type from numpy

What happens to the `replace` flag under this paradigm? `replace` indicates that there was an upstream error in the batch process (e.g., an error in cleaning, or PII leakage) and...

My feeling on this is that there should be a *different* set of parameters in your temporal config, `test_frequency` and `test_interval` or somesuch that determines how many and which *test...

Ah, yes, I said the same thing in #378. Doesn't make me right, just consistent. :)

Another thought on this: We are doing evaluations the same way (making one evaluation over all dates) in both test and train. For EWS problems, presumably, this method is equally...

This also prevents triage from upgrading `pandas` beyond 1.3.5. 1.5.0 will be out soon, so we will continue to face challenges with dependency upgrades and adoption if we do not...

See also the [readme](https://github.com/dssg/triage/tree/master/src/triage/component/results_schema/) and [example database profile](https://github.com/dssg/triage/blob/master/src/triage/component/results_schema/example_db_config.yaml) for the results schema. Despite my improvements, it still contains internal inconsistencies as well as inconsistencies with the triage standard methods.

See also #378 #223 for relevant discussions

Multiple as of dates in test matrices was never intended to be used this way. Instead, timechop is built to anticipate using multiple test matrices for this purpose. Putting all...