Emile Cormier
Emile Cormier
You should put `enum.h` inside an `include/betterenums` subdirectory of your Git repository. This would allow superproject build scripts to clone your Git repo as-is and add `-I superproject/thirdpartylibs/betterenums/include` compiler flags...
See https://github.com/HowardHinnant/date/issues/252#issuecomment-1065969980
As I've reported in #683, parsing ISO 8601 date/time strings via this library (and C++20) is problematic due to the following reasons: - Without using the `%NS` specifier with an...
I would like to keep using this library as a "fallback" for compilers that don't yet support C++20's new date facilities. I need to know exactly what's different between this...
`date::format` currently throws `std::ios_base::failure` upon formatting errors. The C++20 spec mandates that a `std::format_error` be thrown for `chrono` formatting errors ([reference](http://eel.is/c++draft/time.format)). Should `date::format` instead throw a (proposed) `date::format_error`, to be...
Consider making `Session` objects more thread safe. This might entail that `internal::WampMessage` objects can no longer be reused in `internal::Client`, but must be constructed every time a message needs to...
Make `Session` support any Boost.Asio *completion token* via template member functions, instead of providing separate mix-in classes for coroutines, futures, etc.
Verify that the library can be used with Visual Studio 2013. Identify, if necessary, the C++11 features that would need to be worked around to support VS2013.
Consider adding a `Service` class which serves as a facade to a common `Session` instance. Multiple `Service` objects could target the same `Session` instance. A `Service` would take care of...
TCP transports should optionally make use of the RawSocket transport-level [PING](https://github.com/tavendo/WAMP/blob/master/spec/advanced.md#framing) messages to help keep long-lived connections open. The ping interval should be configurable by the user.