Echedey Luis

Results 191 comments of Echedey Luis

Thank you for opening this PR! ❣️ It will take me some time to review this PR in depth, just a heads up so I don't seem rude letting time...

Ready for preview @kandersolar , @AdamRJensen , @cwhanse , the rest of @pvlib/maintainers (I can't ping the team) Feel free to weight in whatever comes to your mind, but firstly...

@mikofski , @adriesse , @markcampanelli would you like to weight in whether pvlib is a good place to include this? So I can determine if I should continue working on...

Seems like there is consensus on not including something like this here, so I'm closing this PR.

In addition to @kandersolar suggestion I want to suggest: 1. Instead of yes, use "x", unicode ticks ✓ or emojis (I prefer unicode ticks for this) 2. Reorder the types...

> > Instead of yes, use "x", unicode ticks ✓ or emojis (I prefer unicode ticks for this) > > I used the ticks at first too, but my editor...

@RDaxini regarding > I could be convinced otherwise, but atm I'm not 100% on board with ticking off variables. Is there a chance we imply more ticks => better, ie...

68 files to organize... I propose splitting up the work to make it manageable. I'd say the first step is to categorize each file. Feel free to react to this...

This is a summary of the classification, available in the spreadsheet's third sheet. ![image](https://github.com/user-attachments/assets/c3dfa1e9-5768-4f1a-8b38-e208a1480de6)

> I guess one might discuss whether you are converting models or sets of parameters. @adriesse , do you have any proposal in mind? For example, `cec_params_to_pvsyst`, `params[_from]_pvsyst_to_cec` [`params_pvsyst2cec`]. I...