Echedey Luis
Echedey Luis
I feel the problem with the preambles is impossible to tackle down. It's more likely something that could be resolved on the matplotlib interface side. BTW, matplotlib provides a way...
Lot of thanks for clearing this up. Now I feel like it's obvious. Don't worry about the review. I know it's premature to open a PR based on another one...
I agree with @williamhobbs. `surface_tilt` and `surface_azimuth` terms seem to apply to all contexts independently of the used tracker, so they are less prone to be misunderstood by a user.
Rebase conflicts solved. Ready for review!
@AdamRJensen I'm pleased to do so. Should I change the function name too?
> I think something that suggests the shade line moves vertically would be best Then vertical / horizontal as you say; only these two (frontal surface) dimensions can be shaded....
Ready for review 👀 Few doubts, notes and ideas: * I've changed the figure and added the reference of backtracking slope-aware, I hadn't seen the angle convention in [this file](https://github.com/pvlib/pvlib-python/blob/92c0e5bcfca717056971c27c556ff443d07d4e4c/docs/sphinx/source/_images/ground_slope_angle_convention.png)....
Thanks Kevin for the in-depth review. I agree 100% on all your points. Maybe some tricks could be made by checking whether the Sun is on the front or the...
I've changed the scope of this PR to only address the shaded fraction topic. The linear loss model will be left to another PR I'll open in the following days.
Fixed a few things regarding the new implementation 🔧 . Ready to be re-reviewed!