Evgeni Chasnovski

Results 153 comments of Evgeni Chasnovski

I can see that this is debatable, hence an issue first without an actual PR. My reasoning here is that `:terminal` uses background and foreground from `Normal` and not from...

I see. Well, it won't be a default then. This is the same line of reasoning as in "Why change default color scheme if it is better to create 'runtime/colors/neovim.lua'...

@justinmk, do you mind me asking about the executive decision here? Basically, should colors for built-in terminal (`:terminal`) be inherited from default color scheme or left as current is as...

> I've been using "light cyan" for Special. We can use variations of green/blue/gray where we need distinction. No need to add a color to the palette. Using any other...

> QuickFixLine can be bg highlighted with NvimCyan or NvimBlue. It's important that quickfix selection is very obvious, for usability. It's not too noisy. Ok, noted. > We can have...

> 1. I find that the use of bold for keywords is a bit much: it is distracting and pulls my attention to the parts of the code that are...

> > lightness of background was taken from the reference color scheme at the time. > > I appreciate that, but the new theme definitely has less contrast than the...

Just as a side note. I plan to have this for at least a week to gather feedback (at least until after Neovimconf) and make a follow up PR addressing...

> `DiagnosticFloating*` hl groups now has `bg`, so they don't blend with the `NormalFloat`. So they look very odd: > > ![image](https://private-user-images.githubusercontent.com/8050659/287606249-1d764005-5e98-4223-bce9-503aa16e7577.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDE2ODM5NTAsIm5iZiI6MTcwMTY4MzY1MCwicGF0aCI6Ii84MDUwNjU5LzI4NzYwNjI0OS0xZDc2NDAwNS01ZTk4LTQyMjMtYmNlOS01MDNhYTE2ZTc1NzcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQUlXTkpZQVg0Q1NWRUg1M0ElMkYyMDIzMTIwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyMzEyMDRUMDk1NDEwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2Y1ZDkyMDIxN2I4MzUxZGI1ZDNhNjZlNDg0MDUxMDMyOTQwNDFmNjM4ZTM3MWNlNzg3MDA3NWFiNTU1NmNlNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.Wml12ZsZuGGrbdlE-tQ29rvxXnEscHVMybin9cR42Qg) > > These hl groups should only define...

> Noticed that with the default colorscheme in background=light mode, the cursor is almost not readable. > > Not sure if this is expected (like do I need to tune...