Marcel Ebert

Results 38 comments of Marcel Ebert

Hey there. Have you tried if this also happens on a fresh clone of Solar? I noticed that when I fresh clone the repo, npm install the modules and `npm...

I'm using node version `v16.13.0` but I think older versions should also work. And yes that you are using windows could indeed be the reason for this. I assumed you...

How it's done in similar apps: LOBSTR vault: - only mnemonic imports / no secret key import - create or import account with 12 word mnemonic phrase - looking at...

Thoughts from our (private) discussion: - Hard to establish consistent concept since it's not possible to obtain a mnemonic phrase from a secret key with BIP-39. - We could only...

Although the details of the export remain unclear for now, we should still add the import feature to increase convenience for our users.

I re-designed the layout of the backup sheet. It now looks like this: on Android: on iOS: Any suggestions for improvement of the bottom text are appreciated.

Hmm I guess it does not look so 'harsh' this way. I have to have a look if I can rotate 'Public Key' and 'Secret Key' to point upwards, IIRC...

I added your suggested changes. It now looks like this which should be pretty close to what you imagined.

I had a look at it and as far as i can tell the only two things that are useful here are [buildChallengeTx](https://stellar.github.io/js-stellar-sdk/Utils.html#.buildChallengeTx) and [readChallengeTx](https://stellar.github.io/js-stellar-sdk/Utils.html#.readChallengeTx). `buildChallengeTx()` can be used to...

I see. Seems like what we could do is replace the [`assertChallengeOK()`](https://github.com/satoshipay/stellar-sep-10/blob/667fa0c95070752963060ebb2f860b4a775a8b6e/src/authentication.ts#L5) helper function with `readChallengeTx()` since they both validate the challenge transaction (see source code of `readChallengeTx` [here](https://stellar.github.io/js-stellar-sdk/libdocs_utils.js.html)) But...