Zeming Lin

Results 46 comments of Zeming Lin

Hi @kirill-pinigin! This project is officially a part of the PyTorch API now: https://github.com/pytorch/pytorch/tree/master/torch/csrc/api It currently cannot be built in Windows, although we are working on this.

Here's the main API for the lazy: https://github.com/ebetica/autogradpp/pull/70/files#diff-ffe21efa98aef140628a9045de88f753R47

Sounds like you guys are happy with this? I should go an implement all the other missing Tensor functions that are not also in Functions.h, and write some tests on...

It's always a battle between how much compile time safety we have and how much flexibility we allow our users. I wish C++ could somehow statically check the types of...

The unordered_map is optional dictionary of returns, like {"policy_output": Tensor.sizes() = [8], "value_output": Tensor.sizes() = [1], "policy_embeddings": Tensor.sizes() = [8, 64], ...}

@goldsborough @jgehring I think the crux of the issue is that our Containers are ```c++ variable_list forward(variable_list) = 0; ``` So we _already_ have no compile time guarantees. This PR...

@syhw notes that we can have both, variants for the daring and templates for the strong of will.

@jgehring What are best practices regarding move and copy constructors? I defined default (good for maps and stuff), copy, move, and move assignment.

Yeah this is totally possible I think. ```c++ template class Container_CRTP { Variant unchecked(Variant x) override { static_cast(this)->checked(magic_unpack(x)); } } ``` Unfortunately, the template-fu in my quick Google search seems...

Also, @goldsborough mentioned not wanting an extra dependency to do serialization. If it could be cross platform across pytorch too, it might be useful. Maybe serialization can be implemented in...