Results 26 comments of Erik Berg

With the introduction of a new volume, I broke some tests which were dependent on volumes arranged in a fixed order, I can cherry-pick the fix in question provided from...

> Hello what's the status here? I don't think it is simply solved by refactoring `common.sh`, `install.sh` or the `prepare` file. I tried to refactor the files a bit to...

I think this is pretty complete. Not quite sure about the `when: zabbix_proxy_database_creation | bool` constructions. You kinda want them there if you're passing variables from the command line. I've...

Hmm, the CentOS one we can probably fix by forcing python3? I'll have to do some digging when it comes to the ubuntu fails.

Apologies for the hold up, been busy trying to get my own actions-runner working so I can get these results myself, as currently I'm currently just testing against [a few...

I've created a separate PR #1218 for some CI stuff, and this PR has been rebased on that. The geerlingguy centos7 image comes without python3, and we should all be...

> Not sure why you put the same CI changes in here. Won't say remove them but need to fix the conflict you have. I needed the CI stuff in...

> As a rule we always squish commits. Can you make an exception for these PRs? As you see there's quite a bit of documentation in each commit. And if...

I'm all for this, I think it would make a great addition to the 3.0.0 release. You'll have wait and rebase once #1272 merges, but it should be much easier...

Thank you for taking a look :smiley: > We cleaned up a lot of it, but kept the same basic form-factor of task distribution. I'm not opposed to doing that,...