Ebben Aries

A few comments as I think some restructuring should be revisited wrt. transport security for gRPC endpoints in general and as it relates to potential restructuring within: https://github.com/openconfig/public/pull/1096 * We...

> Adding a backwards compatibility note. As currently proposed, a client / management system must know the type of interface in order to access the speed of the interface. (ie:...

> The CI check with pyang detected some issue, probably related to naming changes in the yang groupings. Can you fix @earies ? This check actually appears to open a...

> For this particular change, perhaps a simple description update would be sufficient? Sadly that is the likely fastest/easiest option here but this represents a bigger issue. Raised https://github.com/openconfig/public/issues/1193 for...

@cfyo @dplore - please re-review - the PR has been updated to remove any `when` statements and describe behavior within description statements. This should be looked at as a temporary...

> @earies can you provide a tree rendering? I am not seeing any breaking change now? If that is true, can you revise the model version to a non-breaking change?...

Initial refactored tree of `/system/grpc-servers` _NOTE: Various existing services would be in need of refactoring for consistency and alignment of config/state_ ``` module: openconfig-system +--rw system +--rw oc-sys-grpc:grpc-servers +--rw oc-sys-grpc:grpc-server*...

> Looks to me there are some redundancy. For example, how would you interpret the difference in these two paths: > > system/grpc-servers/grpc-server[name=gnmi]/config/enable > > system/grpc-servers/grpc-server[name=gnmi]/services/gnmi/config/enable The first is the...

> Looks to me there are some redundancy. For example, how would you interpret the difference in these two paths: > > system/grpc-servers/grpc-server[name=gnmi]/config/enable > > system/grpc-servers/grpc-server[name=gnmi]/services/gnmi/config/enable The motivation behind above...

Apologies for the delay as other items took precedence - Just to provide an update as I'll be looping back to this PR shortly, addressing previous comments along w/ some...