Ebben Aries
Ebben Aries
LGTM
SGTM - I'd suggest just opening a PR to add the relevant node For JUNOS, you can reference https://www.juniper.net/documentation/us/en/software/junos/interfaces-ethernet/topics/ref/command/show-chassis-hardware.html
> I suggest we leave the name as "MODULE" because if the module is a child of a LINECARD it is obviously a LINECARD_MODULE, etc. As was stated above in...
IMO there are more concerns here wrt. JSON related encodings in this context First - your target N2 assumes aggregation of nodes and for that they truly all need to...
Some initial comments/feedback: * Various implementations do not implement port-mirroring in this fashion thus this caters closer to 1 specifically. Implementation differences can vary greatly here much like is seen...
@robshakir @aashaikh - it appears by the last comment this is likely resolved and also a pending PR https://github.com/openconfig/public/pull/482/files - when will this be published to public/master?
@robshakir @dplore - can someone PTAL? thx
> Sorry - meant to add a top-level comment. > > Are these being removed because they are harmful, or because they aren't consistently used through every enumeration? If it's...
@robshakir - I believe you are referencing my statement > RE: Backwards compatibility and the major version bump. If we look back on commit history, OpenConfig models to date have...
@nokia1adam agreed we have a type mismatch for the intention here. The `protocol` instance name was a loose design pattern for extensibility that in most circumstances would only ever see...