Julian Coy

Results 25 comments of Julian Coy

Yeah it's been a while since I've touched this library. I think there is a LOT that can be done in regards to testing. Thanks for the suggestions.

Thanks, yeah that's not a bad idea. The API isn't the cleanest for GoDaddy to be honest. But at least it is stable, haha. If I get some free time...

I put up a PR with a limit on recursion #1549 I have a few questions: how many days should we limit the recursion to? Also the approach is something...

It's immutable. ```ts const a = currency(0); const b = a.add(1); console.log(a.value); // 0 console.log(b.value); // 1 ``` It's one of the main features:

So I think this whole PR can be replaced by a simple wrapper type that we provide in either documentation or we add it and export somewhere (might need to...

> I'd say start as a copy-paste pattern, and only add if we need to. New APIs are forever :) Yeah, my preference is just making it a copy-paste kinda...

Is there currently a way to work around this by removing the current authentication? I can't seem to find it. Reinstalling seems to work, but it's very cumbersome.

@sorokin-evgeni What version of TypeScript are you running this with? I think 4.1 is the one that supports [recursive conditional types](https://devblogs.microsoft.com/typescript/announcing-typescript-4-1-beta/#recursive-conditional-types). [This playground link](https://www.typescriptlang.org/play?#code/C4TwDgpgBAChBOBbArsAhsAlgewHYB4AVAGigGkBeQgPigoCgomoBtQgXSggA9gJcAJgGdWuCADcE7RsyYB+VtNlMAXOS69+w8jOVQFLMqQB0puElQYcBAKLcAxgBtkAiEVJlq1JXqhqxkvD09KCQsAgofAJ04RboWHj4AORoSVAAPlBJAEZJtFAA9AWsKUmkOUmcmSwVGVmp0qHQ5pEQAgBCqO2YAOY9CDEtlgkEpXW1mUn2eUxFJanlueXTVfNlWdOLlXU1S-XrU9uZpsZAA) should show that it works.

@Dsan10s: > This is one of the best explanations I've seen on the subtleties of TypeScript, period. Thank you @eXamadeus ! Thanks! I am really glad people are finding it...