Eugene Voloshchak

Results 102 comments of Eugene Voloshchak

@Ollyws's [proposal](https://github.com/Expensify/App/issues/11300#issuecomment-1268444864) looks great! Good job spotting that potential performance issue with `ReportUtils.getDisplayNamesWithTooltips` 🎀👀🎀 C+ reviewed @puneetlath

@Ollyws, looks readable to me, let's proceed with the PR UPD: I think this is effectively the same `const formattedText = _.isEmpty(pronouns) ? displayName : '${displayName} (${pronouns})';`

> @eVoloshchak `const formattedText = _.isEmpty(pronouns) ? displayName : '${displayName} (${pronouns})';` You would prefer it this way round? Yup

**Root cause:** When we long press on an email/link,[ BaseAnchorForCommentsOnly's](https://github.com/Expensify/App/blob/main/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.js) [onSecondaryInteraction](https://github.com/Expensify/App/blob/6c53be1ea7a022e8a5e788cc7e7efd62c4573474/src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.js#L62) is fired, calling `ReportActionContextMenu.showContextMenu` with a corresponding type (`CONTEXT_MENU_TYPES.EMAIL` or `CONTEXT_MENU_TYPES.LINK`). Howewer, since `BaseAnchorForCommentsOnly` is wrapped inside a second...

> Root cause seems correct but I don't like the proposal. I've found a simpler fix: The issue arises because in [PressableWithSecondaryInteraction/index.js](https://github.com/Expensify/App/tree/main/src/components/PressableWithSecondaryInteraction/index.js), we have a LongPressGestureHandler, which wraps Pressable, so...

> Ok. What is the base of this solution? Why do you think we should/have to do this? > > The proposal is still lacking the proper explanation of Why...

> I understood the root cause. I got your solution and how this works. But what I am asking is why your solution(Workaround)? > > Why do you think we...

@jayeshmangwani, thanks for the proposal! It is based on @Ollyws's [proposal](https://github.com/Expensify/App/issues/11948#issuecomment-1307260394) with the exception of using Report.navigateToConciergeChat(), which in turn also calls `DrawerActions.closeDrawer()`, so the proposals are identical

@Ollyws, thanks, you've correctly identified the root cause of the issue > The root cause of this issue is that on smaller screens, despite being on the Concierge route the...

I'm talking about this case https://user-images.githubusercontent.com/9059945/200853314-5a1dd839-5e82-4979-b4ce-ba4deb58dee8.mov > if we were to make the drawer close on every report route the user would be presented with a chat instead of the...