Valentin
Valentin
Apologies if this more suited for the forum. I feel this is a bug with the documentation. I am not looking for help with my specific repository. I am reporting...
Hmm, good question. The exchange currently rejects `buyToken == sellToken` so it would also make sense for it to be an error in the `Element` parsing. That being said, it...
More correct. We're using average because originally that was the only parameter available.
which at the moment still blindly trust the symbols. We now have the address in TokenBaseInfo.
https://gnosisinc.slack.com/archives/C6Z2XNL5Q/p1592840939157900?thread_ts=1592832541.145000&cid=C6Z2XNL5Q We should implement a health and readiness check. We should make the price estimator not have downtime when the pod is updated in production. --- As a readiness check...
Not sure if or how we fix this but wanted to document the problem. I have multiple PRs that are supposed to be merged in a row and depend on...
https://github.com/gnosis/dex-services/pull/1295 discovered that an almost zero price will change to infinite when inversed which fails the debug assertion in LimitPrice. When this is fixed we can merge the PR.
This would have caught https://github.com/gnosis/dex-services/pull/975 . > Maybe we should add notifications in our coverage decreases significantly on a single PR: https://docs.coveralls.io/coveralls-notifications to be notified of issues in the future?
The solver needs price estimates. Historically we have been using external sources to provide these like kraken, dexag, 1inch. In #842 we implemented the pricegraph as a source of price...
https://github.com/gnosis/dex-services/issues/970#issuecomment-651025369 @marcovc > If the solver was given price estimates for all tokens as an input, then it wouldn't need to do any more fancy computations. This should be guaranteed...