Diego Frias
Diego Frias
I'm interested in working on this. Is the annotations syntax still the best way of doing this?
I have a basic implementation for extending `BinaryReaderIR` to support reading custom sections. As of right now, I'm more concerned with how to actually represent the custom sections in the...
> Hmm, the latter seems maybe a bit more explicit and cleaner? I agree. I think I'll end up doing it this way, and if I run into problems, I'll...
Can this be closed now that the PR has been merged?
Hmm ok. I'll work on finding a solution that works, then!
> Could you please also add a few more tests, e.g. a roundtrip test for the example given in https://github.com/WebAssembly/annotations/blob/main/proposals/annotations/Overview.md (under "Expressing names")? Looking at this test, it seems I...
Upon working on the implementation of the work in my above comment, it seems like there are many possible places one could use the `@name` annotation. Is there a well-defined...
I'll wait until WebAssembly/annotations#21 is resolved. If the `$"name"` syntax is approved, then most of these problems shouldn't be relevant anymore.
Thanks for reporting the bug! I tried a fix with 52da9b412b14f11924477efe0359b86e97f3eb0d, but I wasn't able to recreate the error myself, so I don't know if it works. Swallowing that error...
Yeah, you're completely right. I have some ideas for helping the startup time. Currently, the main bottleneck in that area is the path sorting algorithm. If I can find a...