Dženan Zukić

Results 237 comments of Dženan Zukić

Has this been fully accomplished? If so, we can close the issue.

Part of this issue was recently handled by @tbirdso by running scripts from #3457. This might be even ripe for closing now.

Looking forward to reviewing the contribution!

Example of an exotic type: `GradientType`: [1](https://github.com/InsightSoftwareConsortium/ITK/blob/971aef211cad336ba75cb2da114fc86e873444e5/Modules/Segmentation/LevelSetsv4/include/itkLevelSetBase.h#L180) [2](https://github.com/InsightSoftwareConsortium/ITK/blob/f81578bbb6242032b611d7e3e4dca3b7557fbbe0/Modules/Core/Common/include/itkConicShellInteriorExteriorSpatialFunction.hxx#L104-L109) [3](https://github.com/InsightSoftwareConsortium/ITK/blob/971aef211cad336ba75cb2da114fc86e873444e5/Modules/Segmentation/LevelSetsv4/include/itkDiscreteLevelSetImage.hxx) A large part of the job is finding instances of these types and replacing custom printing operators by the new specialized...

And of course printing instances of these types as ivars now that it is convenient to print them.

This seems to be partly a duplicate of https://github.com/zlib-ng/zlib-ng/issues/1279.

I vote to wait until 5.3.0 final is tagged before merging this. By the way, PerformanceBenchmarking is [currently broken on unix](https://open.cdash.org/viewBuildError.php?buildid=7456319): `Modules/Core/Common/include/itkFixedArray.h:266:29: error: 'constexpr const ValueType& itk::FixedArray::operator[](unsigned int) const' cannot...

I created a [PR](https://github.com/InsightSoftwareConsortium/ITKPerformanceBenchmarking/pull/92) to check whether that is the issue.

Option 2 is reasonable, but does clang-format fight against it? Also, I was not complaining. I was merely being wowed by how big that file has gotten 😄